Update minimum required CMake version to 3.5#717
Merged
TheAssassin merged 1 commit intoTheAssassin:masterfrom May 23, 2025
Merged
Update minimum required CMake version to 3.5#717TheAssassin merged 1 commit intoTheAssassin:masterfrom
TheAssassin merged 1 commit intoTheAssassin:masterfrom
Conversation
hyperupcall
changed the title
|
I can verify that this also affects the ArchLinux $ yay -Syu --sudoloop
[...SNIP...]
==> Making package: appimagelauncher-git r1329.3d42d4c-2 (Fri 23 May 2025 02:27:48 PM MDT)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> WARNING: Using existing $srcdir/ tree
==> Starting pkgver()...
==> Starting build()...
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.5 has been removed from CMake.
Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
to tell CMake that the project requires at least <min> but has been updated
to work with policies introduced by <max> or earlier.
Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
-- Configuring incomplete, errors occurred!
==> ERROR: A failure occurred in build().
Aborting...
-> error making: appimagelauncher-git-exit status 4cc: @FabioLolix Note: This still depends on AppImageCommunity/AppImageUpdate@673af3cbe79f and needs this version be updated. It will also need one more change to update CMake min version here |
TheAssassin
approved these changes
May 23, 2025
Owner
|
Thanks! |
|
Also seems CMake version needs to be updated in a few more sub-dependencies: |
This was referenced May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building AppImageLauncher, I came across the error:
The error shows when I use CMake v4.0.2, but not when I switch back to v3.31.7. Updating the minimum version to 3.5 fixed the issue for me.
I have also made a PR for AppImageUpdate.